Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirro core] extend the app details page for spaces #38

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

edinalakatos
Copy link
Contributor

No description provided.

@jeanmartin
Copy link
Member

This seems to have been abandoned. Should we merge it?

* 'Gigs completed' with numeric details
* 'Details' link leading to the details page of the given space

![Card view](https://github.com/edinalakatos/cirro-guides/blob/Cirro-Core%5D-Extend-the-app-details-page-for-Spaces/src/images/card-view.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should not point to github but to the path within the app

@@ -0,0 +1,33 @@
## Mandatory information upon space creation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where should we link this article?


Your space description needs to contain the **company name**, a **link** to a publicly available website or landing page, a **support contact email address** and **Social links**.

![Space description](https://github.com/edinalakatos/cirro-guides/blob/Cirro-Core%5D-Extend-the-app-details-page-for-Spaces/src/images/space-description.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should link to the internal path and not github

* contact information
* supported interface languages

![Detailed view](https://github.com/edinalakatos/cirro-guides/blob/Cirro-Core%5D-Extend-the-app-details-page-for-Spaces/src/images/space-details.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link should not point to github but to the path within the app

Copy link
Member

@garciaf garciaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the asset handling should not be on github

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants