Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable session cache by default #332

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sethterashima
Copy link
Collaborator

A session cache can reduce the number of Fleet API calls made by clients, but needed to be explicitly enabled by the user. With this change, the cache will be enabled by default and saved to ~/.tesla-cache.json. This path can be overridden using the -session-cache command-line flag or by setting TESLA_CACHE_FILE, as before.

Users can add the -disable-session-cache command-line flag to disable the feature.

Description

Please include a summary of the changes and the related issue.

Fixes # (issue)

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

A session cache can reduce the number of Fleet API calls made by
clients, but needed to be explicitly enabled by the user. With this
change, the cache will be enabled by default and saved to
~/.tesla-cache.json. This path can be overridden using the
`-session-cache` command-line flag or by setting TESLA_CACHE_FILE, as
before.

Users can add the `-disable-session-cache` command-line flag to disable
the feature.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant