tesla-control: enable/disable valet mode #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agbpatro
approved these changes
Oct 21, 2024
| @@ -13,8 +15,41 @@ import ( | |||
| "github.com/teslamotors/vehicle-command/pkg/protocol/protobuf/vcsec" | |||
| ) | |||
|
|
|||
| // IsValidPIN returns true if the pin is four digits. | |||
| func IsValidPIN(pin string) bool { | |||
There was a problem hiding this comment.
nit: can we have some tests for this method?
Adds valet mode commands to the tesla-control CLI tool. These commands were already supported in the library and HTTP proxy.
sethterashima
force-pushed
the
valet-mode
branch
from
58af559
to
3237260
Compare
aaronpkahn
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds valet mode commands to the tesla-control CLI tool. These commands were already supported in the library and HTTP proxy.
Description
Please include a summary of the changes and the related issue.
Fixes # (issue)
Type of change
Please select all options that apply to this change:
Checklist:
Confirm you have completed the following steps: