Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove location from vent windows command #241

Conversation

sethterashima
Copy link
Collaborator

@sethterashima sethterashima commented May 17, 2024

The location field is not required or enforced for the vent windows command for vehicles that support this protocol. Removing from the protobuf definition to avoid confusion.

Description

Removes unused protobuf field to avoid causing confusion about whether location is required to close windows.

Fixes #239

Type of change

Please select all options that apply to this change:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation update

Checklist:

Confirm you have completed the following steps:

  • My code follows the style of this project.
  • I have performed a self-review of my code.
  • I have made corresponding updates to the documentation.
  • I have added/updated unit tests to cover my changes.

The location field is not required or enforced for the vent windows
command for vehicles that support this protocol. Removing from the
protobuf definition to avoid confusion.
@itsMeDavidV
Copy link

Great, thanks for clarifying this!

@sethterashima sethterashima merged commit 7bfff28 into teslamotors:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is location needed for VehicleControlWindowAction?
3 participants