feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) #141

ORabbit · 2023-07-17T20:36:52Z

No description provided.

apeabody · 2023-08-10T21:31:15Z

/gcbrun

apeabody

Thanks for the contribution @ORabbit! I have included some suggestions below. Cheers!

apeabody · 2023-08-10T21:39:46Z

main.tf

@@ -195,6 +195,13 @@ resource "google_pubsub_subscription" "push_subscriptions" {
        audience              = lookup(each.value, "audience", "")
      }
    }
+
+    dynamic "no_wrapper" {
+      for_each = lookup(each.value, "no_wrapper", "") ? [true] : []


Rather than a bool, would it make more sense to use a nested block no_wrapper = {write_metadata: false} with a default of null? That would more closely follow the provider and allow for easy addition of additional keys in the future.

apeabody · 2023-08-10T21:40:41Z

README.md

@@ -28,6 +28,8 @@ module "pubsub" {
      x-goog-version             = "v1beta1"                                            // optional
      oidc_service_account_email = "[email protected]"                                     // optional
      audience                   = "example"                                            // optional
+      no_wrapper                 = false                                                // optional


If possible, please add any new variables to an example so they are exercised in the Integration CI: https://github.com/terraform-google-modules/terraform-google-pubsub/tree/master/examples

versions.tf

apeabody · 2023-08-10T21:47:44Z

FYI @ORabbit - The Int CI is returning:

Error: Incorrect condition type

  on ../../main.tf line 200, in resource "google_pubsub_subscription" "push_subscriptions":
 200:       for_each = lookup(each.value, "no_wrapper", "") ? [true] : []
    ├────────────────
    │ each.value is map of string with 5 elements

The condition expression must be of type bool.}
    apply.go:34: 
        	Error Trace:	/builder/home/go/pkg/mod/github.com/gruntwork-io/[email protected]/modules/terraform/apply.go:34
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:393
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:403
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:427
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/utils/stages.go:31
        	            				/builder/home/go/pkg/mod/github.com/!google!cloud!platform/cloud-foundation-toolkit/infra/[email protected]/pkg/tft/terraform.go:427
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; 
        	            	Error: Incorrect condition type
        	            	
        	            	  on ../../main.tf line 200, in resource "google_pubsub_subscription" "push_subscriptions":
        	            	 200:       for_each = lookup(each.value, "no_wrapper", "") ? [true] : []
        	            	    ├────────────────
        	            	    │ each.value is map of string with 5 elements
        	            	
        	            	The condition expression must be of type bool.}
        	Test:       	TestSimple

FYI: Your lookup() has a default of an empty string "", you probably want null.

github-actions · 2023-10-15T23:07:49Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

nicolasbelanger · 2023-11-17T15:22:21Z

Any way we can reopen this one? We're blocked by it... (or maybe there's a workaround?)

nicolasbelanger · 2023-11-17T18:48:40Z

examples/subscriptions_only/main.tf

+    {
+      name                 = "push_payload_unwrapping"
+      push_endpoint        = "https://${var.project_id}.appspot.com/"
+      no_wrapper           = { write_metadata = true }


I think we need something like

no_wrapper = true no_wrapper_write_metadata = true

apeabody · 2023-11-27T22:52:11Z

/gcbrun

github-actions · 2024-01-26T23:09:07Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions · 2024-03-30T23:08:07Z

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

ORabbit added 5 commits July 17, 2023 16:17

Add support for push payload unwrapping (no wrapper)

5af8654

Add support for push payload unwrapping (no wrapper)

e09ac95

Add support for push payload unwrapping (no wrapper)

ce8eb18

Update main.tf

7ffce7d

Update README.md

fa5b50c

ORabbit changed the title ~~feat(push): add support for no_wrapper and pubsub_wrapper in push subscriptions~~ feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) Jul 28, 2023

ORabbit marked this pull request as ready for review July 28, 2023 21:03

ORabbit requested a review from a team as a code owner July 28, 2023 21:03

ORabbit added 2 commits August 10, 2023 14:27

Update versions.tf

cbfcf0f

Merge branch 'terraform-google-modules:master' into master

6f48faa

apeabody requested changes Aug 10, 2023

View reviewed changes

Update main.tf

7c88ed5

github-actions bot added the Stale label Oct 15, 2023

github-actions bot closed this Oct 22, 2023

nicolasbelanger reviewed Nov 17, 2023

View reviewed changes

apeabody reopened this Nov 27, 2023

apeabody requested a review from imrannayer as a code owner November 27, 2023 22:50

Merge branch 'master' into master

a5dce96

github-actions bot removed the Stale label Nov 27, 2023

github-actions bot added the Stale label Jan 26, 2024

ORabbit and others added 2 commits January 29, 2024 16:45

Merge branch 'terraform-google-modules:master' into master

fd4bdf3

Modify no_wrapper definition

eb85854

github-actions bot removed the Stale label Jan 29, 2024

github-actions bot added the Stale label Mar 30, 2024

github-actions bot closed this Apr 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) #141

feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) #141

ORabbit commented Jul 17, 2023

apeabody commented Aug 10, 2023

apeabody left a comment

apeabody Aug 10, 2023

apeabody Aug 10, 2023 •

edited

Loading

apeabody commented Aug 10, 2023

github-actions bot commented Oct 15, 2023

nicolasbelanger commented Nov 17, 2023

nicolasbelanger Nov 17, 2023

apeabody commented Nov 27, 2023

github-actions bot commented Jan 26, 2024

github-actions bot commented Mar 30, 2024

feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) #141

feat(push): Add Pub/Sub Subscription support for push payload unwrapping (no wrapper) #141

Conversation

ORabbit commented Jul 17, 2023

apeabody commented Aug 10, 2023

apeabody left a comment

Choose a reason for hiding this comment

apeabody Aug 10, 2023

Choose a reason for hiding this comment

apeabody Aug 10, 2023 • edited Loading

Choose a reason for hiding this comment

apeabody commented Aug 10, 2023

github-actions bot commented Oct 15, 2023

nicolasbelanger commented Nov 17, 2023

nicolasbelanger Nov 17, 2023

Choose a reason for hiding this comment

apeabody commented Nov 27, 2023

github-actions bot commented Jan 26, 2024

github-actions bot commented Mar 30, 2024

apeabody Aug 10, 2023 •

edited

Loading