Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SID must only include alphanumeric characters #60

Merged
merged 1 commit into from
Dec 20, 2024
Merged

fix: SID must only include alphanumeric characters #60

merged 1 commit into from
Dec 20, 2024

Conversation

HectorQuiroz
Copy link
Contributor

@HectorQuiroz HectorQuiroz commented Dec 20, 2024 •
edited by bryantbiggs
Loading

Description

Fix this bug

Motivation and Context

Breaking Changes

No

How Has This Been Tested?

I ran a terraform plan with this forked version and plan came clear. Using latest version I get:

│ Error: invalid value for statement.0.sid (must only include alphanumeric characters)
│ 
│   with module.terraform-aws-sns.data.aws_iam_policy_document.this[0],
│   on .terraform/modules/terraform-aws-sns/main.tf line 51, in data "aws_iam_policy_document" "this":
│   51: data "aws_iam_policy_document" "this" {

@HectorQuiroz HectorQuiroz mentioned this pull request Dec 20, 2024
Closed
@bryantbiggs bryantbiggs merged commit e4c5800 into terraform-aws-modules:master Dec 20, 2024
7 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 20, 2024
@semantic-release-bot
chore(release): version 6.1.2 [skip ci]
467cfe7 
## [6.1.2](v6.1.1...v6.1.2) (2024-12-20)

### Bug Fixes

* SID must only include alphanumeric characters ([#60](#60)) ([e4c5800](e4c5800))
@antonbabenko
Copy link
Member

This PR is included in version 6.1.2 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: invalid value for statement.0.sid (must only include alphanumeric characters)
3 participants
@HectorQuiroz @antonbabenko @bryantbiggs