Skip to content

Commit

Permalink
fix: Update aws_sns_topic_subscription endpoint to use qualified arn (
Browse files Browse the repository at this point in the history
#231)

This commit updates the `aws_sns_topic_subscription` resource to use the `lambda_function_qualified_arn` output for the `endpoint` value.

Also bump the `lambda` module to `6.8.0`, which is the latest version that maintains compatability with `aws` v4 provider.

Fixes: #230
  • Loading branch information
fatmcgav authored Sep 3, 2024
1 parent 2e72539 commit e95cde8
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ See the [functions](https://github.com/terraform-aws-modules/terraform-aws-notif

| Name | Source | Version |
|------|--------|---------|
| <a name="module_lambda"></a> [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 3.2.0 |
| <a name="module_lambda"></a> [lambda](#module\_lambda) | terraform-aws-modules/lambda/aws | 6.8.0 |

## Resources

Expand Down
4 changes: 2 additions & 2 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -73,14 +73,14 @@ resource "aws_sns_topic_subscription" "sns_notify_slack" {

topic_arn = local.sns_topic_arn
protocol = "lambda"
endpoint = module.lambda.lambda_function_arn
endpoint = module.lambda.lambda_function_qualified_arn
filter_policy = var.subscription_filter_policy
filter_policy_scope = var.subscription_filter_policy_scope
}

module "lambda" {
source = "terraform-aws-modules/lambda/aws"
version = "3.2.0"
version = "6.8.0"

create = var.create

Expand Down

0 comments on commit e95cde8

Please sign in to comment.