Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
termi-official authored Jan 24, 2024
1 parent 84d05e6 commit 4854037
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions src/mesh/coordinate_systems.jl
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Requires a grid with facesets
and a nodeset
* Apex
"""
function compute_LV_coordinate_system(grid::AbstractGrid{dim}, ip_geo_collection::LagrangeCollection) where {dim}
function compute_LV_coordinate_system(grid::AbstractGrid{dim}, ip_geo_collection::VectorInterpolationCollection) where {dim}
@assert dim == 3
@assert length(elementtypes(grid)) == 1
ref_shape = getrefshape(getcells(grid, 1))
Expand Down Expand Up @@ -119,7 +119,7 @@ end

"""
"""
function compute_midmyocardial_section_coordinate_system(grid::AbstractGrid{dim}, ip_geo_collection::InterpolationCollection) where {dim}
function compute_midmyocardial_section_coordinate_system(grid::AbstractGrid{dim}, ip_geo_collection::VectorInterpolationCollection) where {dim}
@assert dim == 3
@assert length(elementtypes(grid)) == 1
ref_shape = getrefshape(getcells(grid,1))
Expand Down
1 change: 0 additions & 1 deletion test/integration/test_ecg.jl
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
@testset "Plonsey1964 3D $geo" for (refshape, geo) in ((RefHexahedron, Hexahedron), (RefTetrahedron, Tetrahedron))
grid = generate_grid(geo, (10, 8, 12))
Ferrite.transform_coordinates!(grid, x->Vec{3}(x.^3))
ip = getinterpolation(LagrangeCollection{1}(), refshape)

dh = DofHandler(grid)
Ferrite.add!(dh, :ϕₘ, ip)
Expand Down

0 comments on commit 4854037

Please sign in to comment.