Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for attributes and Symfony 6.4 #3

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

middlebrain
Copy link

@middlebrain middlebrain commented Mar 18, 2024

Tested with PHP 8.2.x.

All annotation tests passed.

If you replace

use Doctrine\Common\Annotations\AnnotationReader;

with

use Koriym\Attributes\AttributeReader as AnnotationReader;

in

tests/Description/ServiceDescriptionFactoryTest.php
tests/Metadata/ActionMetadataTest.php
tests/Metadata/Driver/AnnotationDriverTest.php
tests/Metadata/MethodMetadataTest.php
tests/Router/ServiceResolverTest.php
tests/Service/ContainerServiceFactoryTest.php

then all attribute tests will pass too.

I don't know how to make both (annotation and attribute tests) work in a single run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant