feat: push docker image also to Github registry #605
+23
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM Thanks for your contribution! 🎉 👍 cc @VoVAllen |
Should be fixed now. |
Thanks! I've rerun the workflow, but it's now failing because I (obviously) don't have the correct docker hub credentials: https://github.com/tobiasdiez/pgvecto.rs/actions/runs/11426048592/job/31788570283 So I have no idea how to properly test these changes. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the docker image is only pushed to the Docker Hub repository. In certain countries dockerhub is not working very reliable, thus this PR proposes to also publish the images to the Github Packages repository.
The code is essentially taken from the cloudnative variant: https://github.com/tensorchord/cloudnative-pgvecto.rs/blob/main/.github/workflows/docker.yml
Test run currently fails already at the build step, so I don't know how to test this: https://github.com/tobiasdiez/pgvecto.rs/actions/runs/11326123877/job/31494425115