Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rounded borders #2449

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
3 changes: 0 additions & 3 deletions src/lib/components/batch-operations/table.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,6 @@
<td class="max-sm:hidden" colspan="4">
<EmptyState title={translate('batch.empty-state-title')}></EmptyState>
</td>
<td class="sm:hidden" colspan="2">
<EmptyState title={translate('batch.empty-state-title')}></EmptyState>
</td>
</TableRow>
{/each}
</Table>
2 changes: 1 addition & 1 deletion src/lib/components/bottom-nav-namespaces.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@

<style lang="postcss">
.namespace {
@apply w-full cursor-pointer rounded border border-transparent text-left text-sm font-medium hover:surface-interactive-secondary focus-visible:surface-interactive-secondary focus-visible:border-inverse focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary/70 dark:focus-visible:border-interactive;
@apply w-full cursor-pointer border border-transparent text-left text-sm font-medium hover:surface-interactive-secondary focus-visible:surface-interactive-secondary focus-visible:border-inverse focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-primary/70 dark:focus-visible:border-interactive;

&.selected {
@apply text-brand;
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/bottom-nav.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -159,10 +159,10 @@

<style lang="postcss">
.namespace-wrapper {
@apply surface-black flex h-10 w-full grow flex-row items-center rounded-lg border border-subtle px-0.5 text-sm dark:focus-within:surface-primary focus-within:border-interactive focus-within:outline-none focus-within:ring-2 focus-within:ring-primary/70;
@apply surface-black flex h-10 w-full grow flex-row items-center border border-subtle px-0.5 text-sm dark:focus-within:surface-primary focus-within:border-interactive focus-within:outline-none focus-within:ring-2 focus-within:ring-primary/70;
}

.nav-button {
@apply relative select-none rounded-lg p-1 text-center align-middle text-xs font-medium uppercase transition-all;
@apply relative select-none p-1 text-center align-middle text-xs font-medium uppercase transition-all;
}
</style>
4 changes: 2 additions & 2 deletions src/lib/components/event/event-details-full.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
{#if showEventGroup}
<div class="w-full p-2">
<div
class="flex flex-col gap-0 overflow-hidden rounded-xl border border-subtle xl:flex-row"
class="flex flex-col gap-0 overflow-hidden border border-subtle xl:flex-row"
>
{#each group.eventList as groupEvent}
{@const attributes = formatAttributes(groupEvent)}
Expand Down Expand Up @@ -76,7 +76,7 @@
{@const attributes = formatAttributes(event)}
{@const details = Object.entries(attributes)}
<div class="w-full p-2">
<div class="w-full overflow-hidden rounded-xl border border-subtle">
<div class="w-full overflow-hidden border border-subtle">
<EventLinksExpanded links={event?.links} />
{#each details as [key, value] (key)}
<EventDetailsRowExpanded {key} {value} {attributes} />
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/event/event-details-row.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,6 @@

<style lang="postcss">
.payload {
@apply overflow-hidden rounded border border-subtle bg-primary px-1 py-0.5 font-mono text-xs;
@apply overflow-hidden border border-subtle bg-primary px-1 py-0.5 font-mono text-xs;
}
</style>
12 changes: 2 additions & 10 deletions src/lib/components/event/event-summary-row.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
{#if pendingAttempt}
<div
class="flex items-center gap-1 {pendingAttempt > 1 &&
'surface-retry rounded px-1 py-0.5'}"
'surface-retry px-1 py-0.5'}"
>
<Icon class="mr-1.5 inline" name="retry" />
{translate('workflows.attempt')}
Expand Down Expand Up @@ -223,7 +223,7 @@
class:typedError
class="row expanded"
>
<td class="expanded-cell w-full" colspan="4">
<td class="expanded-cell w-full">
<EventDetailsFull {group} event={currentEvent} />
</td>
</tr>
Expand Down Expand Up @@ -265,12 +265,4 @@
.typedError .expanded-cell {
@apply border-b-0;
}

.row.typedError {
@apply rounded-lg;

&.expanded {
@apply rounded-b-none;
}
}
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
</p>
<div
class="flex items-center gap-1 {event.attempt > 1 &&
'surface-retry rounded px-1 py-0.5'}"
'surface-retry px-1 py-0.5'}"
>
<Icon class="mr-1.5 inline" name="retry" />
{translate('workflows.attempt')}
Expand All @@ -82,7 +82,7 @@
</tr>
{#if expanded}
<tr class="row expanded">
<td class="expanded-cell w-full" colspan="3">
<td class="expanded-cell w-full">
<EventDetailsFull {group} />
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/event/pending-nexus-summary-row.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
{#if event.attempt}
<div
class="flex items-center gap-1 {event.attempt > 1 &&
'surface-retry rounded px-1 py-0.5'}"
'surface-retry px-1 py-0.5'}"
>
<Icon class="mr-1.5 inline" name="retry" />
{translate('workflows.attempt')}
Expand All @@ -79,7 +79,7 @@
</tr>
{#if expanded}
<tr class="row expanded">
<td class="expanded-cell w-full" colspan="3">
<td class="expanded-cell w-full">
<EventDetailsFull {group} />
</td>
</tr>
Expand Down
10 changes: 2 additions & 8 deletions src/lib/components/feedback-button.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,17 @@

<a {href} target="_blank" data-testid="give-feedback" rel="noreferrer">
<div class="feedback-button">
<div class="feedback-icon">
<Icon class="text-purple-200" name="feedback" height={12} width={12} />
</div>
<Icon class="mr-2 text-purple-200" name="feedback" height={12} width={12} />
Give Feedback
</div>
</a>

<style lang="postcss">
.feedback-button {
@apply flex cursor-pointer items-center justify-between rounded-full px-4 py-2 text-sm text-purple-200 shadow-md;
@apply flex cursor-pointer items-center justify-between px-4 py-2 text-sm text-purple-200 shadow-md;
}

.feedback-button:hover {
@apply bg-slate-700;
}

.feedback-icon {
@apply mr-2 rounded-full border-purple-200;
}
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@
/>
<input
id="import-event-history-file-upload"
class="import-input block rounded-md border border-slate-200 p-2"
class="import-input block border border-slate-200 p-2"
type="file"
accept=".json"
on:change={onFileSelect}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/lines-and-dots/workflow-error.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@
</p>
{/if}
<div
class="mt-2 flex w-full flex-col gap-0 overflow-hidden rounded-xl border border-danger"
class="mt-2 flex w-full flex-col gap-0 overflow-hidden border border-danger"
>
<div class="flex items-center justify-between gap-2 bg-danger px-2 py-2">
<div class="flex items-center gap-2">
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/login-button.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

<style lang="postcss">
.login-button {
@apply flex items-center justify-center rounded-full px-4 py-2 text-sm text-white;
@apply flex items-center justify-center px-4 py-2 text-sm text-white;
}

.login-button:hover {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/panel.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@

<style lang="postcss">
.panel {
@apply rounded-xl border p-8 dark:border-subtle;
@apply border p-8 dark:border-subtle;

&.error {
@apply border-danger bg-danger;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@

<style lang="postcss">
.frequency {
@apply flex h-auto max-h-32 flex-col overflow-auto rounded-lg border border-subtle bg-primary px-2 py-2 font-mono text-sm;
@apply flex h-auto max-h-32 flex-col overflow-auto border border-subtle bg-primary px-2 py-2 font-mono text-sm;
}
</style>
Original file line number Diff line number Diff line change
Expand Up @@ -59,9 +59,7 @@
<MenuButton
class="{noBorderRight ? '!border-r-0' : ''} {noBorderLeft
? '!border-l-0'
: ''} whitespace-nowrap {isNullFilter
? 'rounded-l-none'
: 'rounded-none'}"
: ''} whitespace-nowrap"
id="conditional-menu-button"
controls="conditional-menu"
{disabled}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@
$filter.attribute
} (${translate('workflows.duration-filter-placeholder')})`}
icon="search"
class="w-full"
unroundLeft
class="w-full [&_*]:border-l-0"
bind:value={_value}
on:keydown={handleKeydown}
on:input={validateDuration}
Expand Down
9 changes: 0 additions & 9 deletions src/lib/components/search-attribute-filter/index.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -228,13 +228,4 @@
.filter {
@apply grow;
}

:global(.attribute-selected) {
@apply rounded-r-none;
}

:global(#time-range-filter),
:global(#boolean-filter) {
@apply rounded-l-none;
}
</style>
13 changes: 3 additions & 10 deletions src/lib/components/search-attribute-filter/list-filter.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -44,20 +44,14 @@
labelHidden
id="list-filter"
bind:chips
class="w-full"
class="w-full [&_*]:border-l-0 [&_*]:border-r-0"
removeChipButtonLabel={(chip) =>
translate('workflows.remove-keyword-label', { keyword: chip })}
placeholder="{translate('common.enter')} {$filter.attribute}"
unroundLeft
unroundRight
external
/>
<div class="flex h-fit items-center">
<Button
borderRadiusModifier="square-left"
disabled={!chips.length}
type="submit"
>
<Button disabled={!chips.length} type="submit">
{translate('common.search')}
</Button>
<slot />
Expand All @@ -70,8 +64,7 @@
type="search"
placeholder={`${translate('common.enter')} ${$filter.attribute}`}
icon="search"
class="w-full"
unroundLeft
class="w-full [&_*]:border-l-0"
bind:value={_value}
on:keydown={handleKeydown}
/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
bind:value={_value}
{min}
on:keydown={handleKeydown}
unroundLeft
search
class="-mr-2"
class="-mr-2 [&_*]:border-l-0"
/>
</ConditionalMenu>
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
disabled={$activeQueryIndex !== null}
count={$filter.attribute ? 0 : filters.length}
on:click={() => (searchAttributeValue = '')}
class="text-nowrap {!!$filter.attribute && 'attribute-selected'}"
class="text-nowrap"
>
<svelte:fragment slot="leading">
{#if !$filter.attribute}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@
type="search"
placeholder={`${translate('common.enter')} ${$filter.attribute}`}
icon="search"
class="w-full"
unroundLeft
class="w-full [&_*]:border-l-0"
bind:value={_value}
on:keydown={handleKeydown}
/>
Expand Down
6 changes: 3 additions & 3 deletions src/lib/components/worker-compatibility.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -71,15 +71,15 @@
</TableRow>
{:else}
<tr class="w-full">
<td colspan="6">
<td colspan="2">
<EmptyState title={translate('workers.no-version-sets-found')} />
</td>
</tr>
{/each}
</Table>
<h2 class="flex items-center gap-2" data-testid="workers">
{translate('workers.workers')}
<Badge type="count" class="rounded-sm">{workers?.pollers?.length || 0}</Badge>
<Badge type="count">{workers?.pollers?.length || 0}</Badge>
</h2>
<Table class="mb-6 w-full min-w-[600px] table-fixed">
<caption class="sr-only" slot="caption"
Expand Down Expand Up @@ -161,7 +161,7 @@
</TableRow>
{:else}
<tr class="w-full">
<td colspan={reachability?.buildIdReachability?.length ? 8 : 6}>
<td colspan={reachability?.buildIdReachability?.length ? 6 : 4}>
<EmptyState title={translate('workflows.workers-empty-state')} />
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/worker-rules.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
</TableRow>
{:else}
<tr class="w-full">
<td colspan="6">
<td colspan="4">
<EmptyState title={translate('workers.no-assignment-rules-found')} />
</td>
</tr>
Expand Down Expand Up @@ -104,7 +104,7 @@
</TableRow>
{:else}
<tr class="w-full">
<td colspan="6">
<td colspan="3">
<EmptyState title={translate('workers.no-redirect-rules-found')} />
</td>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/worker-table.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

<h2 class="flex items-center gap-2" data-testid="workers">
{translate('workers.workers')}
<Badge type="count" class="rounded-sm">{workers?.pollers?.length || 0}</Badge>
<Badge type="count">{workers?.pollers?.length || 0}</Badge>
</h2>
<Table class="mb-6 w-full min-w-[600px] table-fixed">
<caption class="sr-only" slot="caption"
Expand Down Expand Up @@ -65,7 +65,7 @@
</TableRow>
{:else}
<tr class="w-full">
<td colspan={6}>
<td colspan="5">
<EmptyState title={translate('workflows.workers-empty-state')} />
</td>
</tr>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
/>
</p>
<div
class="surface-subtle mb-2 overflow-scroll whitespace-nowrap rounded border border-subtle p-2"
class="surface-subtle mb-2 overflow-scroll whitespace-nowrap border border-subtle p-2"
>
<code data-testid="batch-action-workflows-query">
{$workflowsQuery}
Expand Down
10 changes: 2 additions & 8 deletions src/lib/components/workflow/dropdown-filter/conditional.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -4,18 +4,12 @@

<div class="mt-2 transition-all hover:cursor-pointer">
<button class="flex items-center" on:click={() => (conditional = '=')}>
<div
class="ml-4 mr-2 rounded-sm p-1 text-primary"
class:active={conditional === '='}
>
<div class="ml-4 mr-2 p-1 text-primary" class:active={conditional === '='}>
Is
</div>
</button>
<button class="flex items-center" on:click={() => (conditional = '!=')}>
<div
class="ml-4 mr-2 rounded-sm p-1 text-primary"
class:active={conditional === '!='}
>
<div class="ml-4 mr-2 p-1 text-primary" class:active={conditional === '!='}>
Is Not
</div>
</button>
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/workflow/input-and-results.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
<h3 class="mb-2 flex items-center gap-2">
{title}
{#if showParsedContentCount}
<Badge type="count" class="rounded-sm">{payloads.length}</Badge>
<Badge type="count">{payloads.length}</Badge>
{/if}
</h3>
{#if content}
Expand Down
Loading
Loading