Border width update #2448
Merged
Border width update #2448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossedfort
approved these changes
Dec 4, 2024
laurakwhit
commented
Dec 4, 2024
| <div | ||
| class="surface-primary max-w-fit rounded-lg border-2 border-secondary p-4" | ||
| > | ||
| <div class="surface-primary max-w-fit rounded-lg border border-secondary p-4"> |
There was a problem hiding this comment.
I'm wondering if we want to override our tailwind theme so that there's only 1 border class and it applies a 1px border.
@rossedfort would we still need to add a border class to every component that needs it though? Just wondering what this would save us, besides maybe "enforcing" border width.
There was a problem hiding this comment.
Yeah, it'd be more about enforcing that we only use a single border width. We can always use arbitrary values if necessary, like border-[3px]. I don't think it necessary, was just a thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Changes border width from
2pxto1px.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?