User Metadata #2423
Merged
User Metadata #2423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use __user_metadata query if it exists * Update unit tests * Fix tests to not mock response
…e Workflow Header to show summary and details and workflow stats above tabs
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…on, don't refetch workflow-metadata for now. Don't show currentDetails
…l on workflow metadata query, use italics in details
rossedfort
approved these changes
Nov 20, 2024
There was a problem hiding this comment.
This seems like it shouldn't be a component, accordion is already pretty light, what's the difference?
There was a problem hiding this comment.
Less padding, no background, no border, different arrow. Probably more what it will be in the future but didn't want to flip them all over
There was a problem hiding this comment.
Let's ask @tigernaut if we can just flip em all over, I'd rather not have 2 versions of accordion
There was a problem hiding this comment.
Not gonna on this PR, but ya I'll chat with them on doing that.
| class="min-w-fit" | ||
| bind:value={name} | ||
| data-testid="signal-select" | ||
| placeholder="Select a signal" |
| <Option | ||
| on:click={handleCustom} | ||
| value="custom" | ||
| description="Input Signal name">Custom</Option |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
With the additional of User Metadata and Workflow Metadata, we can show more human-friendly descriptions of workflows and it's current status.
The Summary/Details field is a static field that comes from the WorkflowDescription API.
The Summary/Detailsinfo and the Workflow info (start/end/duration...) will now be above the fold so it will be visible for all tabs.
The Markdown component also will swap out {namespace}, {workflowId} and {runId} strings the the page params to be able to link dynamically.
This also updates the Send Signal modal to use a Select of signal definitions if they exist.
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?