KeywordList search attribute support #2420
Conversation
laurakwhit
requested review from
stevekinney,
Alex-Tideman and
rossedfort
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurakwhit
force-pushed
the
DT-2505-KeywordList-search-support
branch
from
44d405c to
4a72641
Compare
Could we keep the tags here in the input (like start workflow?) 
|
| @@ -18,12 +18,17 @@ | |||
| export let hintText = ''; | |||
| export let validator: (value: string) => boolean = () => true; | |||
| export let removeChipButtonLabel: string | ((chipValue: string) => string); | |||
| export let unroundRight = false; | |||
| export let unroundLeft = false; | |||
| export let external = false; | |||
There was a problem hiding this comment.
Could we keep the tags here in the input (like start workflow?)
@Alex-Tideman we explored keeping the chips in the input, but after talking with design (cc @tigernaut) we opted for this external chip option to make sure this works with the existing filter (otherwise there are some questions r.e. the border on the input and responsiveness).
There was a problem hiding this comment.
Can we add a comment explaining what external is?
There was a problem hiding this comment.
I had added a story for this, might that suffice?
src/lib/components/workflow/search-attribute-input/index.svelte
Outdated
Show resolved
Hide resolved
| @@ -18,12 +18,17 @@ | |||
| export let hintText = ''; | |||
| export let validator: (value: string) => boolean = () => true; | |||
| export let removeChipButtonLabel: string | ((chipValue: string) => string); | |||
| export let unroundRight = false; | |||
| export let unroundLeft = false; | |||
| export let external = false; | |||
There was a problem hiding this comment.
Can we add a comment explaining what external is?
| @@ -163,6 +185,14 @@ | |||
| @apply surface-primary inline-block w-full focus:outline-none; | |||
| } | |||
|
|
|||
| .unroundRight { | |||
There was a problem hiding this comment.
Could we just do something like first-child: or whatever?
There was a problem hiding this comment.
I looked into this and it was it not as simple as that (it's not the first child for one thing), but if we can figure out how to get this working with modifiers I'll update this for all our input components.
Description & motivation 💭
KeywordListsearch attributes.KeywordListcustom search attributes to a Schedule.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
KeywordListcustom search attribute (e.g.temporal operator search-attribute create --namespace default --name CustomKeywordListField --type KeywordList)CustomKeywordListField> enter valuesView Search Input/schedules> Create Schedule > + Add a Search AttributeCustomKeywordListFieldworks as expectedCustomKeywordListFieldworks as expectedCustomKeywordListField> enter valuesView Search InputChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2505Docs
Any docs updates needed?