Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mobile option for playwright tests #2412

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Conversation

laurakwhit
Copy link
Contributor

Description & motivation 💭

Adds mobile vs. desktop projects to run playwright tests against different viewports.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-1935

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested a review from a team as a code owner October 30, 2024 17:54
@laurakwhit laurakwhit requested review from stevekinney and removed request for a team October 30, 2024 17:54
Copy link

vercel bot commented Oct 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 31, 2024 7:23pm

@laurakwhit laurakwhit force-pushed the test-different-screen-sizes branch from 0d13e48 to ae48c73 Compare October 31, 2024 19:22
@laurakwhit laurakwhit marked this pull request as ready for review October 31, 2024 20:13
playwright.config.ts Show resolved Hide resolved
src/lib/components/bottom-nav-settings.svelte Show resolved Hide resolved
@laurakwhit laurakwhit merged commit 3a423d2 into main Nov 6, 2024
14 checks passed
@laurakwhit laurakwhit deleted the test-different-screen-sizes branch November 6, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants