Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nexus form with searchable combobox #2355

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Nexus form with searchable combobox #2355

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
79cc0e4
support multiselect in combobox
rossedfort Sep 26, 2024
cadecb2
Use combobox with multiselect
Alex-Tideman Sep 26, 2024
8f8875d
Update label
Alex-Tideman Sep 26, 2024
84040bc
Fix merge conflicts
Alex-Tideman Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 13 additions & 22 deletions src/lib/pages/nexus-form.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
import Input from '$lib/holocene/input/input.svelte';
import Editor from '$lib/holocene/monaco/editor.svelte';
import Markdown from '$lib/holocene/monaco/markdown.svelte';
import MultiSelect from '$lib/holocene/select/multi-select.svelte';
import ToggleButton from '$lib/holocene/toggle-button/toggle-button.svelte';
import ToggleButtons from '$lib/holocene/toggle-button/toggle-buttons.svelte';
import { translate } from '$lib/i18n/translate';
Expand Down Expand Up @@ -84,16 +83,6 @@
value: n.namespace,
label: n.namespace,
}));
$: initialCallerNamespaces =
endpoint?.spec?.allowedCallerNamespaces?.map((n) => {
return { value: n, label: n };
}) || [];

const onCallerNamespaceChange = (
selected: { value: string; label: string }[],
) => {
allowedCallerNamespaces = selected.map((n) => n.value);
};

onDestroy(() => {
$endpointForm = emptyEndpoint;
Expand Down Expand Up @@ -150,19 +139,21 @@
{translate('nexus.allowed-caller-namespaces-description')}
</p>
</div>
<MultiSelect
<Combobox
id="caller-namespace-filter-menu"
multiselect
displayChips={false}
bind:value={allowedCallerNamespaces}
options={callerNamespaces}
initialSelected={initialCallerNamespaces}
label={allowedCallerNamespaces.length
? translate('nexus.selected-namespaces', {
count: allowedCallerNamespaces.length,
})
: translate('nexus.select-namespaces')}
selectAllLabel={translate('common.select-all')}
clearAllLabel={translate('common.clear-all-capitalized')}
initialSelectedAll={false}
onChange={onCallerNamespaceChange}
label={translate('nexus.allowed-caller-namespaces')}
toggleLabel={translate('common.namespaces')}
leadingIcon="search"
noResultsText={translate('common.no-results')}
valid={!!allowedCallerNamespaces.length}
error="Please select at least one Namespace."
placeholder={translate('nexus.select-namespaces')}
optionValueKey="value"
optionLabelKey="label"
/>
</IsOssGuard>

Expand Down
Loading