Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
The
toSeconds
util uses intervalToDuration which is expecting an interval object (consisting of twoDates
) to be passed as the parameter and therefore it utilizes the Date constructor.new Date()
creates a datetime in the client timezone which was causing differences in duration (e.g. timer duration ⬇️ )for different users based on what their system timezone was set to.
This PR passes two
Dates
based on UTC instead of relying on the client timezone in instances whereintervalToDuration
is being determined based on seconds.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
If system settings are set to
PDT
will return
{ months: 1, hours: 7, minutes: 853, seconds: 102419 }
andwill return
{ days: 30, hours: 16, minutes: 46, seconds: 1 }
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-2484
Docs
Any docs updates needed?