Workflow Electron #2335
Closed
Workflow Electron #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix styling for non-expandable Accordion * Update padding on Card to match Accordion * Add AccordionGroup * Make ring inset on focus-within * Fix imports and A11y warning
* Add active styling for nav item * Add isActive check for nav links * Account for if isActive is undefined
* Use AccordionGroup to show all possible failures * Dont use red text * Move source to accordion * Add pending task component and move into accordion group * Fixes from Laura's review
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.19.2...4.20.0) --- updated-dependencies: - dependency-name: express dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.0.13 to 5.2.14. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.2.14/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.2.14/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Alex-Tideman
requested review from
stevekinney,
rossedfort and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
commented
Sep 19, 2024
| $page.url.pathname, | ||
| routeForRelationships(routeParameters), | ||
| )} | ||
| /> |
There was a problem hiding this comment.
I removed the count since we make the query when you go to the tab. And also... would we want to show the full count of relationship (parent/children/grandchildre/cousins) or just children??
GiantRobots
reviewed
Sep 19, 2024
* Update go to 1.23 * Use 1.22.6 * Remove work files * Add go.work to gitignore
* Remove unnecessary coerced Boolean * Pluralize Namespaces badge for Nexus endpoints * Fix action slot on Accordion component * Ignore a11y test on Accordion with action
Co-authored-by: Temporal Data (cicd) <[email protected]>
* Update go version to 1.23 in update ui-server * Use v4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
We now have the ability to fetch the full relationship tree of a workflow. This visual will not only show the child workflows of a workflow, but all child workflows of the root workflow of a workflow. The maximum depth of generations shown is 4, but we can add more if we want. Each node is colored to match it's current status, and the active node (the current page user is on) has an additional black/white background circle to easily discover where you are in the electron.
The visual will replace the table of children.
If there are no child workflows, show the Schedule or First/Next/Previous table.
This PR includes a generic zoom-svg component that let's you zoom in/out and pan.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?