-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for OIDC implicit flow #1879
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
d153a22
to
c548516
Compare
@stevekinney @Alex-Tideman Still a draft and haven't added tests yet but I'm seeking early feedback and guidance on testing against a public IdP. |
c548516
to
0659cfb
Compare
0590201
to
8ec6ebf
Compare
8ec6ebf
to
1a24d07
Compare
1a24d07
to
fc9399f
Compare
fc9399f
to
f2df0ea
Compare
Added some unit tests to maintain coverage. Happy to take feedback on additional testing. |
Added manual testing against an Okta dev app. |
056e219
to
4f70f2b
Compare
4f70f2b
to
1bf1afc
Compare
1bf1afc
to
b882d3d
Compare
b882d3d
to
8f1ed2e
Compare
8f1ed2e
to
662ec4c
Compare
662ec4c
to
f05fcbf
Compare
made changes to address issues found in review. also added unit tests to define the behavior for handling the hash fragment from the callback. |
f05fcbf
to
d25970d
Compare
d25970d
to
1a07994
Compare
1a07994
to
a77d0d7
Compare
a77d0d7
to
5d494ac
Compare
Description & motivation 💭
Work in progress. Addresses #1881.
Adds configurable support for the OIDC Implicit Flow. As that flow is designed for SPAs, this approach shifts auth from the server to the client.
Screenshots (if applicable) 📸
Design Considerations 🎨
Looked at using JS libraries but didn't see a way to mesh it neatly.
Testing 🧪
How was this tested 👻
Manual tests
Worked from this guide. Pointed the server to an Okta development app with the configuration below. Can add other users to the app for reproduction.
Screen.Recording.2024-04-01.at.4.07.01.PM.mov
Unit tests
Updated unit tests and added some more. Opened #1915 for some unrelated tests. Happy to take suggestions for additional areas or manual approaches.
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
#1881
Docs
Any docs updates needed?