Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for abandoned child start events #1715

Closed
wants to merge 4 commits into from

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Oct 27, 2023

Description & motivation 💭

  • Checks for ChildWorkflowExecutionStartedEvents that don't have a corresponding closed event and displays them under Relationships > Children.
  • Fixes rendering bug if there are children without a runId.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

  • Verify child events show up as expected under Relationships > Children
    • when events are in ascending order
    • when events are in descending order
    • when all child events have been completed (no duplicates)
    • when some child started events don't have corresponding closed events

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-1531

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Oct 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
holocene ⬜️ Ignored (Inspect) Oct 27, 2023 6:28pm

@Alex-Tideman
Copy link
Contributor

Alex-Tideman commented Oct 27, 2023

Just a general question: How can you abandon a child workflow? What's the situation where it doesn't complete/fail/cancel/terminate...

Also when I run samples-typescript / child-workflows, I don't get any errors (not on this branch). Do I need to do something to trigger the error?

@laurakwhit
Copy link
Contributor Author

Just a general question: How can you abandon a child workflow? What's the situation where it doesn't complete/fail/cancel/terminate...

Looks like you can abandoned children if the parent needs to close but children are still running.

Also when I run samples-typescript / child-workflows, I don't get any errors (not on this branch). Do I need to do something to trigger the error?

See this comment.

@Alex-Tideman Alex-Tideman self-requested a review October 30, 2023 14:38
@Alex-Tideman Alex-Tideman self-requested a review October 30, 2023 15:49
@Alex-Tideman Alex-Tideman marked this pull request as draft October 30, 2023 16:03
@laurakwhit
Copy link
Contributor Author

laurakwhit commented Oct 30, 2023

Update: In testing it appears that children that haven't completed once a parent with an abandon child policy closes should continue to show up as pending children (even once the children complete). Awaiting further repro. info.

@laurakwhit laurakwhit closed this Oct 31, 2023
@laurakwhit laurakwhit deleted the check-for-started-children branch October 31, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants