Individual Event History page #1694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GraceGardner
requested review from
stevekinney,
Alex-Tideman,
rossedfort and
a team
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
GraceGardner
commented
Oct 16, 2023
Alex-Tideman
approved these changes
Oct 17, 2023
Alex-Tideman
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
This PR creates an individual workflow event page, allowing a user to share specific events via URL to see the details of that event quickly without needing to scroll through event history. If the event id in the URL does not exist in the event history, the page will show a 'No Events Match' result.
This also changes the event summary row opening behavior to allow multiple open rows. It removes auto-opening rows with keyboard navigation.
Screenshots (if applicable) 📸
Design Considerations 🎨
Would love to pair with @tigernaut and see their opinions on user flow.
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
https://temporalio.atlassian.net/browse/DT-1517
Docs
Any docs updates needed?