Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger Schedule immediately #1682

Merged
merged 6 commits into from
Oct 13, 2023
Merged

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Oct 12, 2023

Description & motivation 💭

Add UI to support triggering schedule immediately with all the possible overlap policies.

Add optional description to RadioInput.

Also remove namespace name in schedule view since it's now in nav and make the schedule styles/spacing consistent with the Workflow header.

Screenshots (if applicable) 📸

TriggerSchedule.mov

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Closes #1372 , #1525

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Oct 12, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 8:47pm

@Alex-Tideman Alex-Tideman changed the title Schedule trigger immediately Trigger Schedule immediately Oct 12, 2023
Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a small a11y comment.

Also, did you intentionally swap label and description on the policy radio buttons?
Screenshot 2023-10-12 at 12 30 11 PM

I was thinking something more like this:
Screenshot 2023-10-12 at 12 35 13 PM

src/lib/holocene/radio-input/radio-input.svelte Outdated Show resolved Hide resolved
@Alex-Tideman
Copy link
Contributor Author

Yeah I like yours much more

@Alex-Tideman Alex-Tideman merged commit 939d34b into main Oct 13, 2023
9 checks passed
@Alex-Tideman Alex-Tideman deleted the schedule-trigger-immediately branch October 13, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to trigger a schedule manually from the Web UI
2 participants