Dt 1142 deep linking activities #1659
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
* Add Not equal to option for text filter * Update and refactor getFocusedElementId
* Make copyable UI similar to copy button in CodeBlock * Fix truncation in links without icons * Update snap * Create CopyButton component
* Convert backticks to single quotes * Format files
* Add event filters, lock view from start to end * Make it better with tooltips, collapse vertical, event filters, label improvements * Don't follow mouse * Add togglebuttons group, add displayName to group, cleanup * Add Timeline to Accordion, use start/endOfMinute for min/max to provide a little zoomout ability to see all events * Remove paginated-table changes * Update snapshots and pass testid * Fix float tests * Remove event type filter in timeline * Add types * Fix strings to single quotes
* Add aria-hidden to icon svg if no title provided * Remove default icon and label for IconButton * Update snaps * Update test
Co-authored-by: Temporal Data (cicd) <[email protected]>
stevekinney
reviewed
Oct 13, 2023
|
|
||
| export let eventGroup: EventGroup; | ||
| export let selectedId: string; | ||
| export let onGroupClick: (id: string) => void; | ||
|
|
||
| const handleGroupClick = (id: string) => { | ||
| const { namespace, workflow, run } = $page.params; |
There was a problem hiding this comment.
We can probably just store these variables in the top-level instead of fetching them every time.
| const handleGroupClick = (id: string) => { | ||
| const { namespace, workflow, run } = $page.params; | ||
| const queryParams: Record<string, string> = {}; | ||
| $page.url.searchParams.forEach((value, key) => { |
There was a problem hiding this comment.
Why not just use a reduce? This can probably be broken out into a utility function and unit tested. Now that I think about it, that's probably true for this entire function.
| timeline.fit(); | ||
|
|
||
| if ($page.url.hash) { | ||
| setTimeout(() => { |
There was a problem hiding this comment.
Why are we using a setTimeout here?
| @@ -61,6 +65,19 @@ | |||
|
|
|||
| const onLinkClick = () => { | |||
| expanded = !expanded; | |||
| // Dont delete query params like ?per-page | |||
| const { namespace, workflow, run } = $page.params; | |||
| const queryParams: Record<string, string> = {}; | |||
There was a problem hiding this comment.
Yea, if we're doing this more than once, then we should definitely break it out.
| @@ -54,6 +74,9 @@ | |||
| sort: compact ? 'ascending' : sort, | |||
| }); | |||
| loading = false; | |||
| setTimeout(() => { | |||
There was a problem hiding this comment.
The setTimeout here feels a little bit like a code smell.
| hash = $page.url.hash; | ||
| }); | ||
|
|
||
| function scrollIntoView(target, eventHistory) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Adds :
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-1142
https://temporalio.atlassian.net/browse/DT-1142
Docs
Any docs updates needed?