Update Copyable UI #1656
Merged
Update Copyable UI #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Alex-Tideman
reviewed
Oct 2, 2023
src/lib/holocene/copyable.svelte
Outdated
| on:click={(e) => copy(e, content)} | ||
| > | ||
| <slot> | ||
| <span class={$$props.class} class:select-all={!$$slots.default} | ||
| >{content}</span | ||
| > | ||
| </slot> | ||
| <IconButton | ||
| <button | ||
| on:click={(e) => copy(e, content)} |
There was a problem hiding this comment.
Should we just have a CopyButton component?
There was a problem hiding this comment.
Yeah, was just talking with @tigernaut about this. I think probably? Added ✅ But we likely need to have a bigger discussion of if we want this and IconButton to be variants of the Button component.
laurakwhit
force-pushed
the
update-copyable
branch
from
fa49601 to
93f6da3
Compare
Alex-Tideman
approved these changes
Oct 2, 2023
Alex-Tideman
pushed a commit
that referenced
this pull request
Oct 4, 2023
* Make copyable UI similar to copy button in CodeBlock * Fix truncation in links without icons * Update snap * Create CopyButton component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Updates
Copyablecomponent to look more like the copy button in theCodeBlockcomponent so that it doesn't take up as much height and isn't clipped.Fixes truncation on links without an icon.
Creates reusable
/copyable/button.svelteused in theCopyableandCodeBlockcomponent.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?