PayloadDecoder #1651
Merged
PayloadDecoder #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* make prettier and eslint play nice * add lint:ci so will fail in ci * format all the files * organize imports on save * update snaps from tailwind class order changes * update snaps * add recommended extensions * pr feedback
* Use CodeMirror for event history payloads * Add readonly prop * WIP: add copy icon to copy content in JSONEditor * Make codemirror the new CodeBlock. Need to figure out string new lines and how to update editor on content changes * Add folding, make string the type for content, update styles, make dynamic, remove PRISM * Fix extra stringifying * Fix small issues * Remove null check * Use margin * Fix CodeBlock testid * Add editable class to codeblock * Fix playwright payload tests, better extension logic to prevent lineWrapping on inline codeblocks * Make it more readable, add back storageState
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Alex-Tideman
requested review from
GiantRobots,
stevekinney,
rossedfort and
a team
as code owners
rossedfort
approved these changes
Oct 16, 2023
…issue with json. Add loading to timeline
rossedfort
approved these changes
Oct 16, 2023
rossedfort
reviewed
Oct 16, 2023
| copySuccessIconTitle={translate('copy-success-icon-title')} | ||
| /> | ||
| {#if decodeEventHistory} | ||
| {#key [index, decodeEventHistory]} |
There was a problem hiding this comment.
TIL you can do array keys. is the decodeEventHistory necessary so that we re-render encoded/decoded payloads when the switch is toggled on and off?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Use the PayloadDecoder component to decode payloads and pass to the CodeBlock instead of decoding everything upfront.
The PayloadDecoder accepts
PotentiallyDecodable | EventAttribute | WorkflowEventas a value. It will iterate over the value and decode each payload. You can also pass a key prop to return a value of the decoded object. This is mostly to not show { payloads: "thing" } and instead show "thing".There is no caching of decoded values. So when a PayloadDecoder is rerendered, it will send another decode request. It is up to the codec server implementation to handle caching.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?