UI updates to WorkflowFilterSearch

[laurakwhit]

Description & motivation 💭

Screenshots (if applicable) 📸

Before	After

Design Considerations 🎨

Testing 🧪

How was this tested 👻

• Manual testing
• E2E tests added
• Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

• Verify all types of filters have the close button and it works/looks as expected
• Verify Relative and Absolute Datetime filters work as expected
• Verify Start/End time Datetime filter works as expected

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-1359

Docs

Any docs updates needed?

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
holocene	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 7, 2023 4:54pm
storybook	❌ Failed (Inspect)			Sep 7, 2023 4:54pm

[rossedfort]

Couple of thoughts

1. Were you going to fix the issue where clicking away from the Workflow Status filter doesn't reset it in the dropdown?
2. Should we also use this PR to remove the labs mode check from the new filters?

[rossedfort]

Screen.Recording.2023-09-05.at.1.27.44.PM.mov

Looks like there is some slightly inconsistent behavior here. If the user has selected "relative" but not specified a duration, should we disable the "Apply" button? Similarly, should we disable it if they select "absolute" and clear the date input?

[laurakwhit]

Were you going to fix the issue where clicking away from the Workflow Status filter doesn't reset it in the dropdown?

@rossedfort I have another task for this (DT-1360), but we also may be removing this filter entirely with the addition of Workflow counts.

Should we also use this PR to remove the labs mode check from the new filters?

I'll create a separate task for this and get it approved by product.

Looks like there is some slightly inconsistent behavior here. If the user has selected "relative" but not specified a duration, should we disable the "Apply" button?

I've disabled Apply if relative is selected and there is an error or no specified duration (b006720).

Similarly, should we disable it if they select "absolute" and clear the date input?

The existing behavior for the datetime filter is just to use the current date if there is none specified. I think it would be fine to keep that and allow apply even if the date input is empty.

[rossedfort]

LGTM

Once future enhancement I thought of is disabling the input(s) in the "Relative" option when user has selected "Absolute" and vice versa. It's a bit odd than you can interact with both even when you only have 1 option selected

[laurakwhit]

Once future enhancement I thought of is disabling the input(s) in the "Relative" option when user has selected "Absolute" and vice versa. It's a bit odd than you can interact with both even when you only have 1 option selected

@rossedfort added ✅