Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete the banners #1609

Merged
merged 3 commits into from
Aug 31, 2023
Merged

Delete the banners #1609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fac01a9
Delete the banners
Alex-Tideman Aug 31, 2023
a27c856
Fix merge conflict
Alex-Tideman Aug 31, 2023
950cbd4
Remove github-service
Alex-Tideman Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 0 additions & 54 deletions cypress/integration/banner.spec.js
View file
Open in desktop

This file was deleted.

45 changes: 0 additions & 45 deletions src/lib/components/banner/banner-temporal-version.svelte
View file
Open in desktop

This file was deleted.

35 changes: 0 additions & 35 deletions src/lib/components/banner/banner-ui-version.svelte
View file
Open in desktop

This file was deleted.

54 changes: 0 additions & 54 deletions src/lib/components/banner/banner.svelte
View file
Open in desktop

This file was deleted.

22 changes: 0 additions & 22 deletions src/lib/components/banner/banners.svelte
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions src/lib/i18n/locales/en/common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,6 @@ export const Strings = {
'keyboard-shortcuts': 'Keyboard Shortcuts',
'close-keyboard-shortcuts': 'Close keyboard shortcuts',
none: 'None',
'banner-temporal-version': 'Temporal v{{version}} is available',
'banner-ui-version': 'Temporal UI v{{version}} is available',
'user-profile': 'User Profile',
'arrow-key-up': 'Arrow key up',
'arrow-key-down': 'Arrow key down',
Expand Down
4 changes: 0 additions & 4 deletions src/lib/models/banner-state.ts
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions src/lib/services/github-service.ts
View file
Open in desktop

This file was deleted.

13 changes: 0 additions & 13 deletions src/lib/stores/banner.ts
View file
Open in desktop

This file was deleted.

5 changes: 0 additions & 5 deletions src/lib/types/global.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,6 @@ export type SelectOptionValue = number | string | boolean;

export type BooleanString = 'true' | 'false';

export type UiVersionInfo = {
current: string;
recommended: string;
};

export type DataEncoderStatus = 'notRequested' | 'success' | 'error';

export type Color =
Expand Down
4 changes: 0 additions & 4 deletions src/routes/(app)/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@

import type { PageData } from './$types';

import Banners from '$lib/components/banner/banners.svelte';
import DataEncoderSettings from '$lib/components/data-encoder-settings.svelte';
import SideNavigation from '$lib/components/side-nav.svelte';
import TopNavigation from '$lib/components/top-nav.svelte';
Expand All @@ -28,10 +27,8 @@

import type { DescribeNamespaceResponse as Namespace } from '$types';

export let data: PageData;

Check warning on line 30 in src/routes/(app)/+layout.svelte

View workflow job for this annotation

GitHub Actions / lint 

Component has unused export property 'data'. If it is for external reference only, please consider using `export const data`

$: ({ uiVersionInfo } = data);

let namespaceList: NamespaceListItem[];

$: isCloud = $page.data?.settings?.runtimeEnvironment?.isCloud;
Expand Down Expand Up @@ -104,7 +101,6 @@
<MainContentContainer>
<DataEncoderSettings />
<TopNavigation {logout} {namespaceList} />
<Banners {uiVersionInfo} />
<div
slot="main"
class="flex w-full flex-col gap-4 p-8 h-[calc(100%-2.5rem)]"
Expand Down
11 changes: 1 addition & 10 deletions src/routes/(app)/+layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,11 @@ import { redirect } from '@sveltejs/kit';
import type { LayoutData, LayoutLoad } from './$types';

import { fetchCluster } from '$lib/services/cluster-service';
import { fetchLatestUiVersion } from '$lib/services/github-service';
import { fetchNamespaces } from '$lib/services/namespaces-service';
import { fetchSettings } from '$lib/services/settings-service';
import { getAuthUser, setAuthUser } from '$lib/stores/auth-user';
import type { GetClusterInfoResponse } from '$lib/types';
import type { Settings, UiVersionInfo } from '$lib/types/global';
import type { Settings } from '$lib/types/global';
import {
cleanAuthUserCookie,
getAuthUserCookie,
Expand Down Expand Up @@ -41,16 +40,8 @@ export const load: LayoutLoad = async function ({

const cluster: GetClusterInfoResponse = await fetchCluster(settings, fetch);

const uiVersionInfo: UiVersionInfo = {
current: settings.version,
recommended: settings.notifyOnNewVersion
? await fetchLatestUiVersion(fetch)
: undefined,
};

return {
user,
uiVersionInfo,
settings,
cluster,
};
Expand Down
Loading