Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add count of workers #1601

Merged
merged 5 commits into from
Aug 30, 2023
Merged

Add count of workers #1601

merged 5 commits into from
Aug 30, 2023

Conversation

Alex-Tideman
Copy link
Contributor

@Alex-Tideman Alex-Tideman commented Aug 30, 2023

Description & motivation 💭

Add the total count of workers, helpful if on task-queue page

Screenshots (if applicable) 📸

Screen Shot 2023-08-30 at 11 29 47 AM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Aug 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
holocene ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 8:14pm

Co-authored-by: Laura Whitaker <[email protected]>
Copy link
Contributor

@laurakwhit laurakwhit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need an import Badge from '$lib/holocene/badge.svelte'; in workers-list.svelte and should be good to go 🚀

@Alex-Tideman Alex-Tideman merged commit 082a1d0 into main Aug 30, 2023
@Alex-Tideman Alex-Tideman deleted the worker-count branch August 30, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants