Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Fontsource fonts, add type support to Tailwind config #1600

Merged
merged 8 commits into from
Aug 30, 2023
Merged

Use Fontsource fonts, add type support to Tailwind config #1600

merged 8 commits into from
Aug 30, 2023

Conversation

stevekinney
Copy link
Member

@stevekinney stevekinney commented Aug 29, 2023 •
edited
Loading

  • Pulls in fonts from Fontsource.
  • Removes static font assets.
  • Adds type information to Tailwind configuration.
  • Uses theme values in app.css and tailwind.config.js
  • Uses standard font class for monospace fonts.

@stevekinney stevekinney requested review from rossedfort and a team as code owners August 29, 2023 23:09
@vercel
Copy link

vercel bot commented Aug 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
holocene ⬜️ Ignored (Inspect) Visit Preview Aug 30, 2023 1:02am

@stevekinney stevekinney changed the title Use Fontsource fonts, add type support to Tailwind Config Use Fontsource fonts, add type support to Tailwind config Aug 29, 2023
@Alex-Tideman
Copy link
Contributor

I'm guessing we'll wanna have this same PR for cloud-ui as well. Didn't know about fontsource, that's awesome.

@Alex-Tideman Alex-Tideman self-requested a review August 30, 2023 20:43
@stevekinney stevekinney merged commit 9f37b26 into main Aug 30, 2023
@stevekinney stevekinney deleted the fontsource branch August 30, 2023 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Tideman Alex-Tideman Alex-Tideman approved these changes

@rossedfort rossedfort Awaiting requested review from rossedfort rossedfort is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevekinney @Alex-Tideman