Schedule Frequency as JSON #1598
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Instead of use 'Frequency', should just be 'Schedule Spec'. |
|
|
||
| const intervalSecs = interval?.interval as string; | ||
| const phaseSecs = interval?.phase as string; | ||
| export let inline = false; | ||
| </script> | ||
|
|
||
| <div class="flex flex-col {$$props.class}"> |
There was a problem hiding this comment.
What do you think about adding a max height here on xl screens?
| <div class="flex flex-col {$$props.class}"> | |
| <div class="flex flex-col h-full xl:max-h-96 overflow-scroll {$$props.class}"> |
There was a problem hiding this comment.
Nah I want to show the whole thing, and with this layout we get quite a bit of height on the right side so there's no reason to not take it up.
| import ScheduleFrequency from './schedule-frequency.svelte'; | ||
|
|
||
|
|
||
|
|
||
| import type { IntervalSpec } from '$types'; | ||
|
|
||
| export let calendar: StructuredCalendar | undefined = undefined; | ||
| export let interval: IntervalSpec | undefined = undefined; | ||
| </script> | ||
|
|
||
| <Panel> |
There was a problem hiding this comment.
Wondering if we want this Panel to come after Upcoming Runs (or above Recent Runs) instead of Advanced Settings on smaller screens
There was a problem hiding this comment.
Yeah makes sense
| @@ -87,6 +83,17 @@ | |||
| {/each} | |||
| </td> | |||
| </TableRow> | |||
| <TableRow> | |||
There was a problem hiding this comment.
Do users need to see the entire Schedule Spec in this view? Or would even something smaller like this be adequate? Accessibility wise, it's not great that this is it's own separate row with no relation to the last.
Or, at the very least, maybe we could add a !border-t-0 to remove the top border so the row is more visually connected?
There was a problem hiding this comment.
It's really hard to read the spec when it's small, so we wanted to give it as much width as possible. I'll remove the top border though.
Description & motivation 💭
Due to the infinite combination of possible schedules, instead of trying and failing to use a human readable label, show the calendar and interval as JSON.
Rearrange layout of table row and Schedule view to make the JSON easily viewable and not take up too much space.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?