Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ARIA improvements to errors and alerts #1595

Merged
merged 13 commits into from
Aug 30, 2023
Merged

ARIA improvements to errors and alerts #1595

merged 13 commits into from
Aug 30, 2023

Conversation

laurakwhit
Copy link
Contributor

@laurakwhit laurakwhit commented Aug 28, 2023 •
edited
Loading

Description & motivation 💭

  • Ensures errors are announced with role="alert"
  • Sets display: none; for Alert components whenever possible so that they are loaded in the DOM and screen readers are aware of them and can announce changes
  • Sets role="status" for Alert components that are not urgent
  • Updates Codec settings to utilize Holocene components with built-in accessibility

Screenshots (if applicable) 📸

Before After
Screenshot 2023-08-28 at 3 49 29 PM Screenshot 2023-08-28 at 3 58 37 PM
Screenshot 2023-08-29 at 12 30 52 PM Screenshot 2023-08-29 at 12 36 29 PM
Screenshot 2023-08-29 at 12 50 04 PM Screenshot 2023-08-29 at 12 49 47 PM

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added updated
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

DT-1289

Docs

Any docs updates needed?

@vercel
Copy link

vercel bot commented Aug 28, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
holocene ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2023 5:22pm

@laurakwhit laurakwhit force-pushed the DT-1289-Screen-reader-should-announce-alerts branch from c92ae84 to 86fffe0 Compare August 28, 2023 23:56
@laurakwhit laurakwhit marked this pull request as ready for review August 29, 2023 16:08
@laurakwhit laurakwhit requested review from rossedfort and a team as code owners August 29, 2023 16:08
rossedfort
rossedfort requested changes Aug 29, 2023
View reviewed changes
src/lib/components/codec-endpoint-settings.svelte Outdated Show resolved Hide resolved
src/lib/components/data-converter-port-settings.svelte Outdated Show resolved Hide resolved
src/lib/components/schedule/schedule-form-view.svelte Outdated Show resolved Hide resolved
src/lib/holocene/accordion.svelte Outdated Show resolved Hide resolved
@laurakwhit laurakwhit requested a review from rossedfort August 29, 2023 21:22
rossedfort
rossedfort approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@rossedfort rossedfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just one question

src/lib/holocene/alert.svelte Outdated Show resolved Hide resolved
@laurakwhit laurakwhit merged commit f7cc091 into main Aug 30, 2023
@laurakwhit laurakwhit deleted the DT-1289-Screen-reader-should-announce-alerts branch August 30, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiantRobots GiantRobots GiantRobots left review comments

@rossedfort rossedfort rossedfort approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@laurakwhit @GiantRobots @rossedfort