Use Tailwind layers, rename workflow status classes #1584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stevekinney
commented
Aug 23, 2023
stevekinney
commented
- Moves base styles into the appropriate Tailwind layer.
- Makes workflow status classes generally available.
- Renames workflow status classes for semantic meaning.
- Removes reactive statements in favor of view layer reactivity.
Fix typo in app.css
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
rossedfort
reviewed
Aug 23, 2023
|
|
||
| $: color = colors[status]; | ||
| $: label = humanFriendlyNames[status]; | ||
| $: isRunning = label === humanFriendlyNames.Running; | ||
| </script> | ||
|
|
||
| <span class="flex text-center text-sm font-medium leading-4"> |
There was a problem hiding this comment.
We could just use <Badge /> here and get rid of those extra color styles
<Badge type={color}>
<span class="whitespace-nowrap">{label}</span>
{#if isRunning}
<HeartBeat {delay} />
{/if}
</Badge>
There was a problem hiding this comment.
Let's give it a shot.
rossedfort
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.