Delete the banners (#1609)

* Delete the banners * Remove github-service
temporalio · Aug 31, 2023 · f4e73d9 · f4e73d9
1 parent dd4389f
commit f4e73d9
Show file tree

Hide file tree

Showing 12 changed files with 1 addition and 272 deletions.
diff --git a/cypress/integration/banner.spec.js b/cypress/integration/banner.spec.js
diff --git a/src/lib/components/banner/banner-temporal-version.svelte b/src/lib/components/banner/banner-temporal-version.svelte
diff --git a/src/lib/components/banner/banner-ui-version.svelte b/src/lib/components/banner/banner-ui-version.svelte
diff --git a/src/lib/components/banner/banner.svelte b/src/lib/components/banner/banner.svelte
diff --git a/src/lib/components/banner/banners.svelte b/src/lib/components/banner/banners.svelte
diff --git a/src/lib/i18n/locales/en/common.ts b/src/lib/i18n/locales/en/common.ts
@@ -120,8 +120,6 @@ export const Strings = {
   'keyboard-shortcuts': 'Keyboard Shortcuts',
   'close-keyboard-shortcuts': 'Close keyboard shortcuts',
   none: 'None',
-  'banner-temporal-version': 'Temporal v{{version}} is available',
-  'banner-ui-version': 'Temporal UI v{{version}} is available',
   'user-profile': 'User Profile',
   'arrow-key-up': 'Arrow key up',
   'arrow-key-down': 'Arrow key down',

diff --git a/src/lib/models/banner-state.ts b/src/lib/models/banner-state.ts
diff --git a/src/lib/services/github-service.ts b/src/lib/services/github-service.ts
diff --git a/src/lib/stores/banner.ts b/src/lib/stores/banner.ts
diff --git a/src/lib/types/global.ts b/src/lib/types/global.ts
@@ -111,11 +111,6 @@ export type SelectOptionValue = number | string | boolean;
 
 export type BooleanString = 'true' | 'false';
 
-export type UiVersionInfo = {
-  current: string;
-  recommended: string;
-};
-
 export type DataEncoderStatus = 'notRequested' | 'success' | 'error';
 
 export type Color =

diff --git a/src/routes/(app)/+layout.svelte b/src/routes/(app)/+layout.svelte
@@ -5,7 +5,6 @@
 
   import type { PageData } from './$types';
 
-  import Banners from '$lib/components/banner/banners.svelte';
   import DataEncoderSettings from '$lib/components/data-encoder-settings.svelte';
   import SideNavigation from '$lib/components/side-nav.svelte';
   import TopNavigation from '$lib/components/top-nav.svelte';
@@ -30,8 +29,6 @@
 
   export let data: PageData;
 
-  $: ({ uiVersionInfo } = data);
-
   let namespaceList: NamespaceListItem[];
 
   $: isCloud = $page.data?.settings?.runtimeEnvironment?.isCloud;
@@ -104,7 +101,6 @@
   <MainContentContainer>
     <DataEncoderSettings />
     <TopNavigation {logout} {namespaceList} />
-    <Banners {uiVersionInfo} />
     <div
       slot="main"
       class="flex w-full flex-col gap-4 p-8 h-[calc(100%-2.5rem)]"

diff --git a/src/routes/(app)/+layout.ts b/src/routes/(app)/+layout.ts
@@ -3,12 +3,11 @@ import { redirect } from '@sveltejs/kit';
 import type { LayoutData, LayoutLoad } from './$types';
 
 import { fetchCluster } from '$lib/services/cluster-service';
-import { fetchLatestUiVersion } from '$lib/services/github-service';
 import { fetchNamespaces } from '$lib/services/namespaces-service';
 import { fetchSettings } from '$lib/services/settings-service';
 import { getAuthUser, setAuthUser } from '$lib/stores/auth-user';
 import type { GetClusterInfoResponse } from '$lib/types';
-import type { Settings, UiVersionInfo } from '$lib/types/global';
+import type { Settings } from '$lib/types/global';
 import {
   cleanAuthUserCookie,
   getAuthUserCookie,
@@ -41,16 +40,8 @@ export const load: LayoutLoad = async function ({
 
   const cluster: GetClusterInfoResponse = await fetchCluster(settings, fetch);
 
-  const uiVersionInfo: UiVersionInfo = {
-    current: settings.version,
-    recommended: settings.notifyOnNewVersion
-      ? await fetchLatestUiVersion(fetch)
-      : undefined,
-  };
-
   return {
     user,
-    uiVersionInfo,
     settings,
     cluster,
   };