Add attempt count to HSM tasks #6982
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergundy
reviewed
Dec 13, 2024
There was a problem hiding this comment.
I'm a bit on the fence with this change.
I prefer to expose the attempt count on the events that are relevant to you (I think you might want callbacks to BTW - trying to remember what we decided) instead of adding to the hsm.Task interface and forcing everyone to care about this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Added logic to track attempt count on HSM tasks. Specifically for
nexusoperations.InvocationTaskandnexusoperations.CancelationTaskWhy?
To make this information available to the task executors.
How did you test it?
Updated tests