Don't coalesce closeTime when checking against null #6965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmbarzee
force-pushed
the
jbarzee/visibility-avoid-coalesce-closetime
branch
from
2ad2ef6 to
00e8459
Compare
jmbarzee
force-pushed
the
jbarzee/visibility-avoid-coalesce-closetime
branch
from
00e8459 to
30b9f56
Compare
jmbarzee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Prevent Coalesce of closeTime when checking if (not) null
Why?
To get proper query results when querying visibility with closeTime in where clause
How did you test it?
Start workflow, query for running workflows based on closeTime.
Potential risks
Query results can now be deceptive, returning CloseTimes that have been coalesced when where clause ensured that CloseTime was null.
Also, Depending on SQL Version behavior, indexes may be no longer leveraged and performance may decrease for the relevant queries.
Documentation
N/A
Is hotfix candidate?
No.