Tweak Update rate limit error

temporalio · Dec 10, 2024 · e4e737d · e4e737d
1 parent f2d52ed
commit e4e737d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/service/history/workflow/update/registry.go b/service/history/workflow/update/registry.go
@@ -398,7 +398,8 @@ func (r *registry) checkTotalLimit() error {
 	if len(r.updates)+r.completedCount >= r.maxTotal() {
 		r.instrumentation.countTooMany()
 		return serviceerror.NewFailedPrecondition(
-			fmt.Sprintf("limit on number of total updates has been reached (%v)", r.maxTotal()),
+			fmt.Sprintf("The limit on the number of distinct updates in this workflow has been reached (%v). "+
+				"Make sure any duplicate updates share an Update ID so the server can deduplicate them, and consider rejecting updates that you aren't going to process", r.maxTotal()),
 		)
 	}
 	return nil

diff --git a/tests/update_workflow_test.go b/tests/update_workflow_test.go
@@ -5336,7 +5336,7 @@ func (s *UpdateWorkflowSuite) TestUpdateWithStart() {
 		errs := err.(*serviceerror.MultiOperationExecution).OperationErrors()
 		s.Len(errs, 2)
 		s.Equal("Operation was aborted.", errs[0].Error())
-		s.Contains(errs[1].Error(), "limit on number of total updates has been reached")
+		s.Contains(errs[1].Error(), "limit on the number of distinct updates in this workflow has been reached")
 	})
 }