Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background check replay code snippets for Java and Python #337

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

bergundy
Copy link
Member

The content was incorrect, there's no need to instantiate a test environment to run replays from a file.

I changed the source files and ran yarn getsnips.

@bergundy bergundy requested a review from a team as a code owner November 22, 2024 15:07
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
temporal-learning ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 3:07pm

Copy link
Contributor

@fairlydurable fairlydurable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocking this ticket.

@fairlydurable
Copy link
Contributor

Thanks you for adding these corrections. We appreciate keeping the tutorials up-to-date and usable.

Some changes were mechanical incidentals. Most of our tooling allows you to specify the file you changed so you don't hit other files unintentionally.

@fairlydurable fairlydurable merged commit d67b649 into main Nov 22, 2024
4 checks passed
@bergundy bergundy deleted the fix-replay-code-snippets branch November 26, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants