-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ruff, a drop-in replacement for black #423
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
# isort: skip_file | ||
.venv | ||
__pycache__ | ||
/build | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am worried a lot of things changed in here inadvertently and am also worried that by not using an older version of Poetry we may be forcing users to upgrade (which has its own issues at the moment) |
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change | ||
---|---|---|---|---|
|
@@ -41,7 +41,7 @@ types-protobuf = ">=3.20" | |||
typing-extensions = "^4.2.0" | ||||
|
||||
[tool.poetry.dev-dependencies] | ||||
black = "^23.1.0" | ||||
ruff = "^0.1.5" | ||||
cibuildwheel = "^2.11.0" | ||||
grpcio-tools = "^1.48.0" | ||||
isort = "^5.11.5" | ||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||
|
@@ -68,12 +68,11 @@ grpc = ["grpcio"] | |||
build-develop = "python scripts/setup_bridge.py develop" | ||||
build-develop-with-release = { cmd = "python scripts/setup_bridge.py develop", env = { TEMPORAL_BUILD_RELEASE = "1" }} | ||||
fix-wheel = "python scripts/fix_wheel.py" | ||||
format = [{cmd = "black ."}, {cmd = "isort ."}] | ||||
format = [{cmd = "ruff format ."}] | ||||
gen-docs = "python scripts/gen_docs.py" | ||||
gen-protos = "python scripts/gen_protos.py" | ||||
lint = [ | ||||
{cmd = "black --check ."}, | ||||
{cmd = "isort --check-only ."}, | ||||
{cmd = "ruff check ."}, | ||||
{ref = "lint-types"}, | ||||
{ref = "lint-docs"}, | ||||
] | ||||
|
@@ -117,10 +116,6 @@ build-verbosity = "1" | |||
before-all = "curl https://sh.rustup.rs -sSf | sh -s -- --default-toolchain stable -y && yum install -y openssl-devel" | ||||
environment = { PATH = "$PATH:$HOME/.cargo/bin", CARGO_NET_GIT_FETCH_WITH_CLI = "true" } | ||||
|
||||
[tool.isort] | ||||
profile = "black" | ||||
skip_gitignore = true | ||||
|
||||
[tool.mypy] | ||||
ignore_missing_imports = true | ||||
exclude = [ | ||||
|
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,2 @@ | ||
# Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT! | ||
"""Client and server classes corresponding to protobuf-defined services.""" | ||
import grpc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is needed