Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README updates and CI fixes #403

Merged
merged 2 commits into from
Oct 24, 2023
Merged

README updates and CI fixes #403

merged 2 commits into from
Oct 24, 2023

Conversation

cretz
Copy link
Member

@cretz cretz commented Oct 20, 2023

What was changed

  • Document that there's a gevent sample
  • Document that time-skipping test server doesn't work on ARM

Checklist

  1. Closes Investigate issues with gevent.monkey.patch_all() #59
  2. Closes Document that time skipping test server does not currently work on ARM #379

@cretz cretz requested a review from a team as a code owner October 20, 2023 12:51
dandavison
dandavison approved these changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@dandavison dandavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

josh-berry
josh-berry reviewed Oct 20, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@cretz
Copy link
Member Author

cretz commented Oct 23, 2023

I am moving this to draft while I work on the CI problem

@cretz cretz marked this pull request as draft October 23, 2023 19:18
@cretz cretz changed the title README updates README updates and CI fixes Oct 23, 2023
@cretz cretz force-pushed the gevent-readme branch 2 times, most recently from 772278c to 8beeaf1 Compare October 24, 2023 12:53
@cretz cretz marked this pull request as ready for review October 24, 2023 13:20
@cretz
Copy link
Member Author

cretz commented Oct 24, 2023

CI fixed. Merging.

@cretz cretz merged commit 4242dfb into temporalio:main Oct 24, 2023
11 checks passed
@cretz cretz deleted the gevent-readme branch October 24, 2023 13:20
@cretz cretz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josh-berry josh-berry josh-berry left review comments

@dandavison dandavison dandavison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cretz @dandavison @josh-berry