Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add high-level workflow describe #2326

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Add high-level workflow describe #2326

merged 1 commit into from
Nov 25, 2024

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

closes #2265

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review November 20, 2024 16:39
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 20, 2024 16:39
cretz
cretz reviewed Nov 22, 2024
View reviewed changes
temporal-sdk/src/main/java/io/temporal/client/WorkflowExecutionDescription.java
public class WorkflowExecutionDescription extends WorkflowExecutionMetadata {
private final @Nonnull DescribeWorkflowExecutionResponse response;

public WorkflowExecutionDescription(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make this constructor package private like its super class? I assume this is public because it is interceptable? Not sure the describe call needs to be interceptable if the list call isn't. Or if we want to make the list call interceptable, we can and then expose the constructor of WorkflowExecutionMetadata.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is public because it is intercept-able, It was a requirement on the issue. The list call is not intercept-able right now but it makes sense to open an issue to add that as well and expose the constructor of WorkflowExecutionMetadata, but I would prefer to do that in a separate issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened an issue to track making list intercept-able #2328

@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this pull request Nov 25, 2024
Open
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit a2dd369 into temporalio:master Nov 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz left review comments

@Sushisource Sushisource Sushisource approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add high-level workflow describe
3 participants
@Quinn-With-Two-Ns @cretz @Sushisource