SpringBoot - add workflow and activity metadata to RegisteredInfo #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...gure-alpha/src/main/java/io/temporal/spring/boot/autoconfigure/template/WorkersTemplate.java
Show resolved
Hide resolved
|
Can we also add some basic tests for this? just verify a workflow registered returns the correct metadata? |
Signed-off-by: Tihomir Surdilovic <[email protected]>
tsurdilo
force-pushed
the
springboot-registerinfo-addmetadata
branch
from
790a4a1 to
9c88693
Compare
Signed-off-by: Tihomir Surdilovic <[email protected]>
Signed-off-by: Tihomir Surdilovic <[email protected]>
|
added test lets me know if ok to merge now |
Quinn-With-Two-Ns
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Workflow and Activity metadata to registered info
Tested with sample temporalio/samples-java#576
Now users can get a lot more info about registered workflows and activities:
@Quinn-With-Two-Ns sorry should have added this in the initial pr :) your suggestion to make it object type so we can add more data to it was awesome, allowed for this