Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unwrap ExecutionException on sync update #1974

Merged
merged 1 commit into from
Jan 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,10 @@ public <R> R update(String updateName, Class<R> resultClass, Object... args) {
} catch (InterruptedException e) {
throw new RuntimeException(e);
} catch (ExecutionException e) {
throw new RuntimeException(e);
Throwable cause = e.getCause();
throw (cause instanceof RuntimeException
? (RuntimeException) cause
: new RuntimeException(cause));
}
}

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,98 @@
/*
* Copyright (C) 2022 Temporal Technologies, Inc. All Rights Reserved.
*
* Copyright (C) 2012-2016 Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Modifications copyright (C) 2017 Uber Technologies, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this material except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package io.temporal.client.functional;

import static org.junit.Assert.assertThrows;

import io.temporal.client.*;
import io.temporal.failure.ApplicationFailure;
import io.temporal.testing.internal.SDKTestWorkflowRule;
import io.temporal.workflow.*;
import java.time.Duration;
import org.junit.Rule;
import org.junit.Test;

public class UpdateLongPollTest {
private static final int HISTORY_LONG_POLL_TIMEOUT_SECONDS = 20;

@Rule
public SDKTestWorkflowRule testWorkflowRule =
SDKTestWorkflowRule.newBuilder()
.setUseTimeskipping(false)
.setWorkflowTypes(WorkflowUpdateImpl.class)
.build();

@Test(timeout = 3 * HISTORY_LONG_POLL_TIMEOUT_SECONDS * 1000)
public void testGetUpdateResults() {
TestUpdatedWorkflow workflow = testWorkflowRule.newWorkflowStub(TestUpdatedWorkflow.class);
WorkflowClient.start(workflow::execute);
workflow.update(2 * HISTORY_LONG_POLL_TIMEOUT_SECONDS, false);
workflow.close();
WorkflowStub.fromTyped(workflow).getResult(Void.class);
}

@Test(timeout = 3 * HISTORY_LONG_POLL_TIMEOUT_SECONDS * 1000)
public void testGetUpdateResultsFail() {
TestUpdatedWorkflow workflow = testWorkflowRule.newWorkflowStub(TestUpdatedWorkflow.class);
WorkflowClient.start(workflow::execute);
assertThrows(
WorkflowUpdateException.class,
Comment on lines +56 to +57
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify the cause here is the serialized application failure? (or confirm a test elsewhere confirms the proper thrown exception type from update)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we have lots of other tests that verify the exception type from an update

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I would have expected them to also confirm/deny WorkflowUpdateException was the properly thrown exception, but I am guessing they just validated the cause not the top-level type?

() -> workflow.update(2 * HISTORY_LONG_POLL_TIMEOUT_SECONDS, true));
workflow.close();
WorkflowStub.fromTyped(workflow).getResult(Void.class);
}

@WorkflowInterface
public interface TestUpdatedWorkflow {

@WorkflowMethod
String execute();

@UpdateMethod
void update(int sleepSeconds, boolean failUpdate);

@SignalMethod(name = "endWorkflow")
void close();
}

public static class WorkflowUpdateImpl implements TestUpdatedWorkflow {
CompletablePromise<Void> promise = Workflow.newPromise();

@Override
public String execute() {
promise.get();
return "done";
}

@Override
public void update(int sleepSeconds, boolean failUpdate) {
Workflow.sleep(Duration.ofSeconds(sleepSeconds));
if (failUpdate) {
throw ApplicationFailure.newFailure("test failure", "failure");
}
}

@Override
public void close() {
promise.complete(null);
}
}
}
Loading