Allow WorkflowImplementationOptions to be passed in TestWorkflowExten… #1948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
temporal-testing/src/main/java/io/temporal/testing/internal/SDKTestOptions.java
Outdated
Show resolved
Hide resolved
|
Hi @picpromusic , thank you for the contribution. Just had one small comment on the content. For testing I think your approach is correct, but I would prefer to see |
picpromusic
force-pushed
the
issue-1626
branch
from
b313c1c to
3be5d57
Compare
|
Just an FYI the CI failure looks unrelated to your changes |
|
@Quinn-With-Two-Ns. And how to continue? |
|
@picpromusic I'll need to merge this #1949 and then you can rebase on this. |
|
@picpromusic CI should be fixed https://buildkite.com/temporal/java-sdk-public/builds/2979 please feel free to rebase |
…sion Implement registerWorkflowImplementationTypes for TestWorkflowExtension temporalio#1626 Fix use of deprecated Method in existing tests. Testing the setting indirectly by specifying Default startToCloseTimeout or not.
…sion use setFailWorkflowExceptionTypes instead of timeout-setting
picpromusic
force-pushed
the
issue-1626
branch
from
3be5d57 to
08b2ef1
Compare
Quinn-With-Two-Ns
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
It is possible to configure WorkflowImplementationsOptions using TestWorkflowExtension.
#1626
Why?
In order to configure WorkflowImplementationOptions (like default ActivityOptions) using TestWorkflowExtension two new Methods registerWorkflowImplementationTypes are implemented. I choosed registerWorkflowImplementationTypes and not setWorkflowTypes because I found the registerWorkflowImplementationTypes like the one needed to configure WorkflowImplementationOptions to a worker in "non-test" Code.
Checklist
Closes 1626
How was this tested:
With my tests in a different project and through 2 Unit-Tests. One (TestWorkflowImplementationOptions.java) providing WorkflowImplementationOptions and one not providing the options (which would run into end endless loop). I did not find a more direct-way to tests this. So just testing side-effects of the implementation. An because side-effects might change in future TestWorkflowImplementationOptionsViceVersa.java for testing that TestWorkflowImplementationOptions.java would brake if the side-effect changes.
Any docs updates needed?
I did not find a documentation that needs to be adapted. But https://github.com/temporalio/documentation/blob/main/docs-src/java/testing-frameworks.md should be fixed, It contains a broken link to https://github.com/temporalio/samples-java/tree/main/src/test/java/io/temporal/samples which should be https://github.com/temporalio/samples-java/tree/main/core/src/main/java/io/temporal/samples. As it is a different repository. I will open up another pull-request for it.