Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat signal after workflow complete as NonDeterministicException #1923

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Treat signal after workflow complete as NonDeterministicException #1923

merged 2 commits into from
Nov 9, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Treat signal after workflow complete as NonDeterministicException. I see this exception confusing users as they think their is something wrong with the temporal service or the SDK when it is normally their workflow code.

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review November 6, 2023 16:18
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner November 6, 2023 16:18
@Quinn-With-Two-Ns
Copy link
Contributor Author

Note: not going to merge this right away, targeting v1.23.0

@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 4f0119f into temporalio:master Nov 9, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Quinn-With-Two-Ns @cretz