Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadOnly Exception in update validator fail WFT #1918

Merged
merged 4 commits into from
Oct 30, 2023
Merged

ReadOnly Exception in update validator fail WFT #1918

merged 4 commits into from
Oct 30, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Based on previous discussions ReadOnly exceptions in update validators should still fail the WFT instead of the update

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review October 30, 2023 18:20
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner October 30, 2023 18:20
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 8af4a26 into temporalio:master Oct 30, 2023
4 checks passed
@Quinn-With-Two-Ns Quinn-With-Two-Ns mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Quinn-With-Two-Ns @cretz @Sushisource