Verify history is replayed up to StartedEventId #1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -351,7 +348,7 @@ public void sendQueryTask( | |||
| task.setPreviousStartedEventId(previousStaredEventId); | |||
| // it's not a real workflow task and the server sends 0 for startedEventId for such a workflow | |||
| // task | |||
| task.setStartedEventId(startedEventId); | |||
| task.setStartedEventId(0); | |||
There was a problem hiding this comment.
Can't say why this was done this way since the comment in the code acknowledges it should be zero
cretz
reviewed
Oct 30, 2023
| @@ -264,13 +268,29 @@ private void applyServerHistory(WorkflowHistoryIterator historyIterator) { | |||
| timerStopped = true; | |||
| } | |||
| } | |||
| if (!replayFailed) { | |||
There was a problem hiding this comment.
How can replayFailed ever be true on this line?
There was a problem hiding this comment.
you're right that was an error
Sushisource
approved these changes
Oct 30, 2023
cretz
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify history is replayed up to StartedEventId. Previously the Java SDK did not verify it repalyed up to StartedEventId sent on the poll request when processing a workflow task. This lead to the Java SDK not replaying the full workflow history if it was fetching history using GetWorkflowExecutionHistory after receiving a partial history with no cached execution and hitting a stale history node.
Go SDK also has a similar check: https://github.com/temporalio/sdk-go/blob/3cccbdd5f47d640fffe6651e4f49c236a4803a47/internal/internal_task_handlers.go#L383
closes #1915