Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid incrementing WFT failure metric on respond failure #1887

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Avoid incrementing WFT failure metric on respond failure #1887

merged 2 commits into from
Oct 10, 2023

Conversation

Quinn-With-Two-Ns
Copy link
Contributor

Avoid incrementing WFT failure metric on respond failure. This aligns Java with other SDKs.

closes #1885

@Quinn-With-Two-Ns Quinn-With-Two-Ns marked this pull request as ready for review October 10, 2023 17:04
@Quinn-With-Two-Ns Quinn-With-Two-Ns requested a review from a team as a code owner October 10, 2023 17:04
Sushisource
Sushisource approved these changes Oct 10, 2023
View reviewed changes
Copy link
Member

@Sushisource Sushisource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment needs updating I think. Otherwise LGTM

temporal-sdk/src/test/java/io/temporal/internal/worker/WorkflowWorkerTest.java Outdated Show resolved Hide resolved
@Quinn-With-Two-Ns Quinn-With-Two-Ns merged commit 1fb089f into temporalio:master Oct 10, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sushisource Sushisource Sushisource approved these changes

@cretz cretz cretz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Quinn-With-Two-Ns @cretz @Sushisource