Support Spring Boot 3 native image build #1877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
| @@ -14,7 +14,7 @@ subprojects { | |||
|
|
|||
| compileJava { | |||
| options.encoding = 'UTF-8' | |||
| options.compilerArgs << '-Xlint:none' << '-Xlint:deprecation' << '-Werror' | |||
| options.compilerArgs << '-Xlint:none' << '-Xlint:deprecation' << '-Werror' << '-parameters' | |||
There was a problem hiding this comment.
Can we add -parameters to the compileTestJava task as well?
|
Thanks for the contribution @zhxnlai |
Quinn-With-Two-Ns
approved these changes
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added the
-parameterscompiler argument for several classes, addressing theMissingParametersCompilerArgumentExceptionduring native image compilation in projects using Temporal.Why?
This change is critical to enable users to compile their projects into native images without encountering
MissingParametersCompilerArgumentException. It facilitates smoother and error-free native compilations, especially for projects relying on Temporal’s classes for constructor injection. By ensuring the parameter names are available at runtime via reflection, it mitigates runtime issues and enhances the user experience in native environments.Checklist
Closes
Spring Boot 3 native image support #1840
How was this tested:
The project was built and tested locally, and the
MissingParametersCompilerArgumentExceptionerror was no longer present. Further testing in environments using native images is recommended.No documentation updates are needed as this change is related to the compilation process and does not alter any functionalities or features of the Temporal classes. The users consuming these classes do not require any additional steps or modifications in their usage or integration.