Fix type assertion

temporalio · Nov 22, 2024 · df1d518 · df1d518
1 parent 1946c22
commit df1d518
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 8 deletions.
diff --git a/temporal-sdk/src/main/java/io/temporal/common/metadata/POJOWorkflowInterfaceMetadata.java b/temporal-sdk/src/main/java/io/temporal/common/metadata/POJOWorkflowInterfaceMetadata.java
@@ -210,17 +210,15 @@ private static POJOWorkflowInterfaceMetadata newInstanceInternal(
                   + methodMetadata.getWorkflowMethod().getName()
                   + "\"");
         }
-        if (Arrays.equals(
-                update.getWorkflowMethod().getGenericParameterTypes(),
-                methodMetadata.getWorkflowMethod().getGenericParameterTypes())
-            || update.getWorkflowMethod().getGenericReturnType()
-                == methodMetadata.getWorkflowMethod().getGenericReturnType()) {
+        if (!Arrays.equals(
+            update.getWorkflowMethod().getGenericParameterTypes(),
+            methodMetadata.getWorkflowMethod().getGenericParameterTypes())) {
           throw new IllegalArgumentException(
               "Update method \""
                   + update.getWorkflowMethod().getName()
-                  + "\" and validator method \""
+                  + "\" and Validator method \""
                   + methodMetadata.getWorkflowMethod().getName()
-                  + "\" have the same signature");
+                  + "\" do not have the same parameters");
         }
       }
     }

diff --git a/...oral-sdk/src/test/java/io/temporal/common/metadata/POJOWorkflowInterfaceMetadataTest.java b/...oral-sdk/src/test/java/io/temporal/common/metadata/POJOWorkflowInterfaceMetadataTest.java
@@ -215,7 +215,6 @@ private Class<?> generateWorkflowInterfaceWithQueryMethod(
   public void workflowInterfaceWithUpdateValidator() {
     POJOWorkflowInterfaceMetadata metadata =
         POJOWorkflowInterfaceMetadata.newInstance(GUpdate.class);
-    System.out.println(metadata);
   }
 
   @Test