Skip to content

Commit

Permalink
Fix workflow start delay docs to say signal does not interrupt delay (#…
Browse files Browse the repository at this point in the history
…2190)

Fix start delay docs
  • Loading branch information
Quinn-With-Two-Ns authored Aug 15, 2024
1 parent 7229a45 commit 448f264
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -374,10 +374,8 @@ public Builder setDisableEagerExecution(boolean disableEagerExecution) {
}

/**
* Time to wait before dispatching the first workflow task. If the workflow gets a signal before
* the delay, a workflow task will be dispatched and the rest of the delay will be ignored. A
* signal from signal with start will not trigger a workflow task. Cannot be set the same time
* as a CronSchedule.
* Time to wait before dispatching the first workflow task. A signal from signal with start will
* not trigger a workflow task. Cannot be set the same time as a CronSchedule.
*/
public Builder setStartDelay(Duration startDelay) {
this.startDelay = startDelay;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,6 @@ public void concurrentPollRequestLockTest() throws Exception {
});

assertTrue(worker.start());
// All slots should be available
reporter.assertGauge(
MetricsType.WORKER_TASK_SLOTS_AVAILABLE,
ImmutableMap.of("worker_type", "WorkflowWorker"),
100.0);
// Unblock the first poll
blockFirstPollLatch.countDown();
// Wait until we have got all the polls
Expand Down

0 comments on commit 448f264

Please sign in to comment.